-
Notifications
You must be signed in to change notification settings - Fork 54
Add peadm::add_database
plan
#241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Includes a collection of utility and subplans that can be assembled to add a new external database componenet to a PEADM deployment, a required component of the Extra Large architecture. Databases can be added in both DR and no-DR deployments or if a database is lost, replaced using a still functioning replica as a source of data.
Was originally operating under the assumption that availability group A's database would look to B for reads, eventually realized this was incorrect so removed the functionality.
Adding some comments and renaming the plan responsible for installation so that it is generic, as opposed to database specific.
In doing some research for something else I came to realize that the stopping of pe-puppetserver and pe-puppetdb on the primary will prevent other steps in the workflow to fail when running this through PE. Will need to change that and revalidate. |
69bab51
to
977a9f2
Compare
Changes logic which decides when and where to start, stop, or restart Puppet Server and PuppetDB so that orchestration over PCP is always available. Cleans up some code along the way.
977a9f2
to
ce8ae41
Compare
Validated bolt execution via PCP transport. This is ready for others to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
This is a big enough one that I'm sure it will continue to evolve as it's used but the first implementation looks complete. 🙂
Some reusable things, some not, some reusable with a little extra work. For now, will successfully deploy an external database for use as a PuppetDB backend. Built with the primary use case of converting a Large architecture to Extra Large but is also reasonable as a step in the deployment of a fresh PE installation.